PMD Results

The following document contains the results of PMD 4.2.2.

Files

pl/innosoft/mathj/BaseExpression.java

Violation Line
Use explicit scoping instead of the default package private level 17

pl/innosoft/mathj/Expression.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 17
Avoid modifiers which are implied by the context 19
Avoid modifiers which are implied by the context 21
Avoid modifiers which are implied by the context 23

pl/innosoft/mathj/ParametrizedExpression.java

Violation Line
It is a good practice to call super() in a constructor 21 - 23
These nested if statements could be combined 60 - 62

pl/innosoft/mathj/ReversePolishNotationManager.java

Violation Line
Found 'DU'-anomaly for variable 'unitResultsStack' (lines '27'-'55'). 27 - 55
Found 'DD'-anomaly for variable 'leftOperandValue' (lines '72'-'76'). 72 - 76
Found 'DU'-anomaly for variable 'leftOperandValue' (lines '72'-'99'). 72 - 99
Found 'DD'-anomaly for variable 'rightOperandValue' (lines '73'-'79'). 73 - 79
Found 'DU'-anomaly for variable 'rightOperandValue' (lines '73'-'99'). 73 - 99
Found 'DU'-anomaly for variable 'leftOperandValue' (lines '76'-'99'). 76 - 99
Found 'DU'-anomaly for variable 'rightOperandValue' (lines '79'-'99'). 79 - 99
A method should have only one exit point, and that should be the last statement in the method 83
A method should have only one exit point, and that should be the last statement in the method 85
A method should have only one exit point, and that should be the last statement in the method 87
A method should have only one exit point, and that should be the last statement in the method 89
A method should have only one exit point, and that should be the last statement in the method 91
A method should have only one exit point, and that should be the last statement in the method 93
A method should have only one exit point, and that should be the last statement in the method 111
A method should have only one exit point, and that should be the last statement in the method 115
An empty statement (semicolon) not part of a loop 117
A method should have only one exit point, and that should be the last statement in the method 119
This statement may have some unnecessary parentheses 126
A method should have only one exit point, and that should be the last statement in the method 127
A method should have only one exit point, and that should be the last statement in the method 143
A method should have only one exit point, and that should be the last statement in the method 148
An empty statement (semicolon) not part of a loop 150
A method should have only one exit point, and that should be the last statement in the method 152
A method should have only one exit point, and that should be the last statement in the method 172
A method should have only one exit point, and that should be the last statement in the method 176
A method should have only one exit point, and that should be the last statement in the method 178

pl/innosoft/mathj/SimpleExpression.java

Violation Line
It is a good practice to call super() in a constructor 13 - 14
It is a good practice to call super() in a constructor 16 - 18
It is a good practice to call super() in a constructor 26 - 35

pl/innosoft/mathj/Solver.java

Violation Line
Found 'DU'-anomaly for variable 'rpnManager' (lines '32'-'54'). 32 - 54
Found 'DU'-anomaly for variable 'rpnStackToSolve' (lines '36'-'54'). 36 - 54
Found 'DD'-anomaly for variable 'rpnStackToSolve' (lines '36'-'44'). 36 - 44
Found 'DD'-anomaly for variable 'analyzer' (lines '39'-'41'). 39 - 41
Found 'DD'-anomaly for variable 'analyzer' (lines '39'-'43'). 39 - 43
Found 'DU'-anomaly for variable 'rpnStackToSolve' (lines '44'-'54'). 44 - 54

pl/innosoft/mathj/analyzer/ExpressionAnalyzer.java

Violation Line
Avoid modifiers which are implied by the context 20
Avoid modifiers which are implied by the context 28

pl/innosoft/mathj/analyzer/MathSheetAnalyzer.java

Violation Line
Avoid modifiers which are implied by the context 18
Avoid modifiers which are implied by the context 30

pl/innosoft/mathj/analyzer/ParametrizedExpressionAnalyzer.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 20
A method should have only one exit point, and that should be the last statement in the method 26
A method should have only one exit point, and that should be the last statement in the method 34

pl/innosoft/mathj/analyzer/SimpleExpressionAnalyzer.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 22
Found 'DU'-anomaly for variable 'rpnManager' (lines '27'-'42'). 27 - 42
A method should have only one exit point, and that should be the last statement in the method 37

pl/innosoft/mathj/compiler/ExpressionCompiler.java

Violation Line
Avoid modifiers which are implied by the context 22

pl/innosoft/mathj/compiler/javacc/JavaCCEquationCompiler.java

Violation Line
An empty statement (semicolon) not part of a loop 63
Found 'DD'-anomaly for variable 'token' (lines '116'-'119'). 116 - 119
Found 'DU'-anomaly for variable 'token' (lines '119'-'143'). 119 - 143
Found 'DD'-anomaly for variable 'parameter' (lines '133'-'134'). 133 - 134
Found 'DU'-anomaly for variable 'currentOperatorPriority' (lines '146'-'166'). 146 - 166
Use explicit scoping instead of the default package private level 169
Avoid assignments in operands 242
Found 'DU'-anomaly for variable 'oldToken' (lines '242'-'252'). 242 - 252
Avoid assignments in operands 272
A method should have only one exit point, and that should be the last statement in the method 273
Found 'DD'-anomaly for variable 'la1tokens' (lines '284'-'286'). 284 - 286
Found 'DD'-anomaly for variable 'la1tokens' (lines '284'-'289'). 284 - 289
Found 'DD'-anomaly for variable 'la1tokens' (lines '286'-'286'). 286
Found 'DD'-anomaly for variable 'la1tokens' (lines '286'-'289'). 286 - 289
Found 'DD'-anomaly for variable 'la1tokens' (lines '286'-'296'). 286 - 296
Found 'DU'-anomaly for variable 'la1tokens' (lines '286'-'313'). 286 - 313
Found 'DD'-anomaly for variable 'la1tokens' (lines '289'-'296'). 289 - 296
Found 'DU'-anomaly for variable 'la1tokens' (lines '289'-'313'). 289 - 313
Found 'DD'-anomaly for variable 'la1tokens' (lines '296'-'296'). 296
Found 'DU'-anomaly for variable 'la1tokens' (lines '296'-'313'). 296 - 313
Found 'DD'-anomaly for variable 'exptokseq' (lines '308'-'310'). 308 - 310
Found 'DD'-anomaly for variable 'exptokseq' (lines '310'-'310'). 310

pl/innosoft/mathj/compiler/javacc/JavaCCEquationCompilerTokenManager.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 36
A method should have only one exit point, and that should be the last statement in the method 45
A method should have only one exit point, and that should be the last statement in the method 47
A method should have only one exit point, and that should be the last statement in the method 49
A method should have only one exit point, and that should be the last statement in the method 51
A method should have only one exit point, and that should be the last statement in the method 53
A method should have only one exit point, and that should be the last statement in the method 55
A method should have only one exit point, and that should be the last statement in the method 57
A method should have only one exit point, and that should be the last statement in the method 59
A method should have only one exit point, and that should be the last statement in the method 61
A method should have only one exit point, and that should be the last statement in the method 71
A method should have only one exit point, and that should be the last statement in the method 77
Found 'DU'-anomaly for variable 'j' (lines '121'-'238'). 121 - 238
Do not start a literal by 0 unless it's an octal value 189
Do not start a literal by 0 unless it's an octal value 217
Found 'DU'-anomaly for variable 'kind' (lines '230'-'238'). 230 - 238
Avoid assignments in operands 233
Found 'DU'-anomaly for variable 'i' (lines '233'-'238'). 233 - 238
A method should have only one exit point, and that should be the last statement in the method 234
Use explicit scoping instead of the default package private level 239 - 241
Use explicit scoping instead of the default package private level 248 - 250
Use explicit scoping instead of the default package private level 251 - 253
Use explicit scoping instead of the default package private level 307
Use explicit scoping instead of the default package private level 308
Use explicit scoping instead of the default package private level 309
Use explicit scoping instead of the default package private level 310
Use explicit scoping instead of the default package private level 311
Use explicit scoping instead of the default package private level 312
Found 'DU'-anomaly for variable 'specialToken' (lines '317'-'378'). 317 - 378
Found 'DU'-anomaly for variable 'curPos' (lines '319'-'378'). 319 - 378
A method should have only one exit point, and that should be the last statement in the method 332
Do not start a literal by 0 unless it's an octal value 347

pl/innosoft/mathj/compiler/javacc/ParseException.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 99
Found 'DU'-anomaly for variable 'tok' (lines '116'-'135'). 116 - 135
Avoid assignments in operands 180

pl/innosoft/mathj/compiler/javacc/SimpleCharStream.java

Violation Line
Use explicit scoping instead of the default package private level 12
Use explicit scoping instead of the default package private level 13
Use explicit scoping instead of the default package private level 14
Avoid assignments in operands 112 - 113
Found 'DU'-anomaly for variable 'i' (lines '112'-'129'). 112 - 129
A method should have only one exit point, and that should be the last statement in the method 189
This statement may have some unnecessary parentheses 198
Avoid assignments in operands 238
A method should have only one exit point, and that should be the last statement in the method 362
Assigning an Object to null is a code smell. Consider refactoring. 386
Assigning an Object to null is a code smell. Consider refactoring. 387
Assigning an Object to null is a code smell. Consider refactoring. 388
Found 'DD'-anomaly for variable 'k' (lines '408'-'411'). 408 - 411
Found 'DD'-anomaly for variable 'j' (lines '408'-'411'). 408 - 411
Found 'DD'-anomaly for variable 'nextColDiff' (lines '409'-'415'). 409 - 415
Found 'DU'-anomaly for variable 'nextColDiff' (lines '409'-'437'). 409 - 437
Found 'DU'-anomaly for variable 'columnDiff' (lines '409'-'437'). 409 - 437
Avoid assignments in operands 411 - 412
Found 'DU'-anomaly for variable 'k' (lines '411'-'437'). 411 - 437
Found 'DU'-anomaly for variable 'columnDiff' (lines '417'-'437'). 417 - 437
Avoid assignments in operands 428

pl/innosoft/mathj/compiler/javacc/TokenMgrError.java

Violation Line
Use explicit scoping instead of the default package private level 13
Use explicit scoping instead of the default package private level 18
Use explicit scoping instead of the default package private level 23
Use explicit scoping instead of the default package private level 28
Use explicit scoping instead of the default package private level 34
Avoid assignments in operands 73
Overriding method merely calls super 114 - 116
It is a good practice to call super() in a constructor 122 - 123

pl/innosoft/mathj/factory/MathSheetFactory.java

Violation Line
Avoid modifiers which are implied by the context 20
Avoid modifiers which are implied by the context 31
Avoid modifiers which are implied by the context 42

pl/innosoft/mathj/factory/xml/MathSheetXmlParser.java

Violation Line
Found 'DD'-anomaly for variable 'expression' (lines '95'-'98'). 95 - 98
Found 'DD'-anomaly for variable 'expression' (lines '95'-'100'). 95 - 100
Found 'DU'-anomaly for variable 'expression' (lines '95'-'130'). 95 - 130
This statement may have some unnecessary parentheses 110
Found 'DU'-anomaly for variable 'textCharacters' (lines '138'-'171'). 138 - 171
Found 'DU'-anomaly for variable 'expressions' (lines '158'-'171'). 158 - 171

pl/innosoft/util/dependecies/DependencyNode.java

Violation Line
Avoid modifiers which are implied by the context 15
Avoid modifiers which are implied by the context 17

pl/innosoft/util/dependecies/DependencyResolver.java

Violation Line
A method should have only one exit point, and that should be the last statement in the method 59
A method should have only one exit point, and that should be the last statement in the method 69
A method should have only one exit point, and that should be the last statement in the method 80
A method should have only one exit point, and that should be the last statement in the method 125
A method should have only one exit point, and that should be the last statement in the method 130
A method should have only one exit point, and that should be the last statement in the method 150
Found 'DD'-anomaly for variable 'dependeciesDependent' (lines '154'-'157'). 154 - 157
A method should have only one exit point, and that should be the last statement in the method 187
A method should have only one exit point, and that should be the last statement in the method 197
A method should have only one exit point, and that should be the last statement in the method 205